Add ClaimableAwaitingConfirmations::BalanceSource#138
Add ClaimableAwaitingConfirmations::BalanceSource#138tnull merged 1 commit intolightningdevkit:mainfrom
ClaimableAwaitingConfirmations::BalanceSource#138Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
tankyleo
force-pushed
the
2026-03-balance-source
branch
from
5b596ee to
fb4ff8f
Compare
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Maybe I'm missing something, but AFAICT we should be able to drop those custom implementations for SCREAMING_SNAKE_CASE?
| Htlc = 3, | ||
| } | ||
|
|
||
| impl BalanceSource { |
There was a problem hiding this comment.
AFAIU, there is no need for this custom impl, serde has SCREAMING_SNAKE_CASE.
| /// Indicates whether the balance is derived from a cooperative close, a force-close (for holder or counterparty), | ||
| /// or whether it is for an HTLC. | ||
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ||
| #[cfg_attr(feature = "serde", serde(rename_all = "snake_case"))] |
There was a problem hiding this comment.
| #[cfg_attr(feature = "serde", serde(rename_all = "snake_case"))] | |
| #[cfg_attr(feature = "serde", serde(rename_all = "SCREAMING_SNAKE_CASE"))] |
There was a problem hiding this comment.
this is auto generated so idk if we can really edit these files
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Experimented a bit with alternate approached but didn't get to a materially different point right now. Will go ahead and land this.
4 participants
No description provided.